fix: enhance VRMSpringBone and VRMSpringBonePhysicsStrategy with opt… #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mized calculations - Refactored VRMSpringBone to improve the calculation of currentTail and prevTail positions, utilizing a more efficient approach for handling world and local positions. - Updated VRMSpringBonePhysicsStrategy to streamline inertia calculations and reduce temporary vector usage, enhancing performance in bone physics transformations. - Removed unnecessary temporary vectors to simplify the code and improve clarity in the physics strategy calculations.
emadurandal
force-pushed
the
fix/vrm-spring-bone-center
branch
from
ebeb56d to
11af6fa
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…imized calculations