Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: ability to specify docker org for baseimg #276

Closed

Conversation

russkel
Copy link
Contributor

@russkel russkel commented Nov 15, 2022

At the moment nvidia is being slow at pushing out ubuntu 22.04 cudagl images and we've been forced to create our own. This patch lets users use their own organisation images instead of nvidia's.

This adds a -baseorg argument to the build command.

@slonopotamus
Copy link
Collaborator

I'm +1 on the spirit of this PR (make base image more configurable), bit -1 on actual implementation. It makes more sense to make base image fully configirable. Many usecases do not involve rendering at all and would happily use ubuntu-nn.mm for exame, without any connection to nvidia stuff.

@russkel
Copy link
Contributor Author

russkel commented Dec 22, 2022

I agree. I did this quick hack because I needed to quickly move on. Specifying the image in entirety is likely a better move.

@russkel
Copy link
Contributor Author

russkel commented Dec 22, 2022

I will remake this to make it a baseimg override instead.

@patrick-5546
Copy link
Contributor

I think changing the base image to nvidia:cuda instead of nvidia:cudagl also works:

@russkel
Copy link
Contributor Author

russkel commented May 3, 2023

@patrick-5546 thanks a lot for bringing this to my attention. I have changed my build to use cuda now. You should create a PR for it ;).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants