Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update baseimg from nvidia/cudagl to nvidia/cuda #315

Merged
merged 2 commits into from
May 4, 2023

Conversation

patrick-5546
Copy link
Contributor

@patrick-5546 patrick-5546 commented May 3, 2023

The Docker image nvidia/cudagl has been deprecated and replaced with nvidia/cuda. The new image has the updated cuda repo signing key so that sudo apt update works, but deprecates some tags: see the Announcement section of https://hub.docker.com/r/nvidia/cuda for more details, and #276 for some context.

What I did is replace every instance of cudagl with cuda in the codebase.

References

@slonopotamus
Copy link
Collaborator

I wonder what do we do with nvidia/opengl...

@slonopotamus
Copy link
Collaborator

slonopotamus commented May 3, 2023

WRT CI failure, looks like we hit docker/docker-py#3113

I'm currently trying to figure out how we workaround that.

@russkel
Copy link
Contributor

russkel commented May 4, 2023

Thanks @patrick-5546

@slonopotamus
Copy link
Collaborator

Could you please rebase onto latest master branch, so that CI tries to run again?

@russkel
Copy link
Contributor

russkel commented May 12, 2023

@patrick-5546 I seem to be getting issues with it not finding a suitable Vulkan surface renderer when it tries to bring up the editor interface. It compiles the shaders fine but after that it fails.

Have you run 5.0+ with the CUDA base image?

Edit: I found we have to do the following apt install https://gitlab.com/nvidia/container-images/vulkan/-/blob/master/docker/Dockerfile.ubuntu#L28 to get it to report the vulkan devices properly.

@russkel
Copy link
Contributor

russkel commented May 12, 2023

This is my fix. I have the 5.2 editor running in Docker.
Greenroom-Robotics@b8bd152

@patrick-5546
Copy link
Contributor Author

Edit: I found we have to do the following apt install https://gitlab.com/nvidia/container-images/vulkan/-/blob/master/docker/Dockerfile.ubuntu#L28 to get it to report the vulkan devices properly.

I believe I also had to install vulkan-utils to get it working on ue4.

@russkel
Copy link
Contributor

russkel commented May 13, 2023

Edit: I found we have to do the following apt install https://gitlab.com/nvidia/container-images/vulkan/-/blob/master/docker/Dockerfile.ubuntu#L28 to get it to report the vulkan devices properly.

I believe I also had to install vulkan-utils to get it working on ue4.

Okay good to know. Maybe I will make a PR for this. Now called vulkan-tools.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants