Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

sp-checkbox text isn't aligned properly #353

Closed
adixon-adobe opened this issue Dec 9, 2019 · 1 comment · Fixed by #354
Closed

sp-checkbox text isn't aligned properly #353

adixon-adobe opened this issue Dec 9, 2019 · 1 comment · Fixed by #354
Assignees
@adixon-adobe
Labels
1.0.0 Issues that should be addressed for a 1.0 release! bug Something isn't working

Comments

@adixon-adobe
Copy link
Collaborator

Expected Behaviour

Label text baseline matches SpectrumCSS

Actual Behaviour

Our baseline is higher because of adobe/spectrum-css#243

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Compare https://opensource.adobe.com/spectrum-web-components/components/checkbox and https://opensource.adobe.com/spectrum-css/components/checkbox/
@adixon-adobe adixon-adobe added bug Something isn't working 1.0.0 Issues that should be addressed for a 1.0 release! labels Dec 9, 2019
@adixon-adobe adixon-adobe self-assigned this Dec 9, 2019
@adixon-adobe
Copy link
Collaborator Author

Let's just monkey-patch this for now until there's a spectrum-css fix.

adixon-adobe added a commit that referenced this issue Dec 9, 2019
@adixon-adobe
fix: #353 with a temporary override
b5ba169 
We should update this when
adobe/spectrum-css#243 is fixed.
@adixon-adobe adixon-adobe mentioned this issue Dec 9, 2019
Merged
2 tasks
adixon-adobe added a commit that referenced this issue Dec 9, 2019
@adixon-adobe
fix: #353 with a temporary override
a87c60f 
We should update this when
adobe/spectrum-css#243 is fixed.
Westbrook pushed a commit that referenced this issue Dec 9, 2019
@adixon-adobe @Westbrook
fix: #353 with a temporary override
e6b4e37 
We should update this when
adobe/spectrum-css#243 is fixed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@adixon-adobe adixon-adobe

Labels
1.0.0 Issues that should be addressed for a 1.0 release! bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #353 with a temporary override adobe/spectrum-web-components
1 participant
@adixon-adobe