Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: #353 with a temporary override #354

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Conversation

adixon-adobe
Copy link
Collaborator

@adixon-adobe adixon-adobe commented Dec 9, 2019

We should update this when
adobe/spectrum-css#243 is fixed.

Description

Just a small override to work around some global styling in spectrum-css.

Related Issue

fixes #353

Motivation and Context

How Has This Been Tested?

Compared the doc site locally with sp-checkbox (I did notice some color differences, but the line-height issue is fixed).

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x ] I have signed the Adobe Open Source CLA.
  • [ x ] My code follows the code style of this project.
  • [ x ] My change requires a change to the documentation.
  • [ x ] I have updated the documentation accordingly.
  • [ x ] I have read the CONTRIBUTING document.
  • [ x ] I have added tests to cover my changes.
  • [ x ] All new and existing tests passed.

@Westbrook
Copy link
Contributor

This will likely change the visual regression this, but I'll be happy to approve this once that's confirmed.

Separately, if you use fixes #353 in the "Related" section of the PR description, merging this should automatically close the issue as well, unless you intend to leave that issue oven until the Spectrum CSS issue is cleared up.

We should update this when
adobe/spectrum-css#243 is fixed.
@adixon-adobe adixon-adobe force-pushed the adixon/353-checkbox-alignment branch from b5ba169 to a87c60f Compare December 9, 2019 22:52
Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Westbrook Westbrook merged commit dc9cf05 into master Dec 9, 2019
@Westbrook Westbrook deleted the adixon/353-checkbox-alignment branch December 9, 2019 23:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sp-checkbox text isn't aligned properly
2 participants