Compute guid on .toString() version of the message. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using Ember i18n service, or any string which is an Ember SafeString
and have the `{ preventDuplicates: true }` option work as expected.
|
LGTM, thanks! @homu r+ |
|
📌 Commit 9bdcd4d has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Mar 3, 2016
…poteto
Compute guid on .toString() version of the message.
Hello!
This PR allows using Ember i18n service, or any string which is an Ember SafeString and have the `{ preventDuplicates: true }` work by computing the guid value on the stringified version of the message. Before, it computed the guid directly, so two different instance of the same objet would get different guid. I added a test to cover the case.
Note: there is a test failing, but it was failing before too.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR allows using Ember i18n service, or any string which is an Ember SafeString and have the
{ preventDuplicates: true }work by computing the guid value on the stringified version of the message. Before, it computed the guid directly, so two different instance of the same objet would get different guid. I added a test to cover the case.Note: there is a test failing, but it was failing before too.