Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add SafeString As A Valid Message Type #387

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ardeliatay
Copy link

@ardeliatay ardeliatay commented Aug 25, 2022

Fix Argument of type SafeString' is not assignable to parameter of type 'string' TS error when passing a SafeString to the flash message service methods:

this.flashMessages.success(htmlSafe('Success!'));
// Argument of type SafeString' is not assignable to parameter of type 'string'

This ticket added SafeString as a valid argument to the flash message methods, but currently the type for message is only a string. This PR introduces a Message type for message arguments to include SafeString to align with that behaviour.

@ardeliatay ardeliatay changed the title Fix message type Add SafeString As A Valid Message Type Aug 25, 2022
@ardeliatay ardeliatay marked this pull request as ready for review August 26, 2022 17:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant