Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix vm-update hook access to api #597

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix vm-update hook access to api #597

merged 1 commit into from
Jan 27, 2025

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Jan 21, 2025

Summary by CodeRabbit

  • Version Updates

    • Updated virtual-machine package version from 0.7.0 to 0.7.1
    • Updated vm-instance package version from 0.4.0 to 0.4.1
  • Configuration Changes

    • Added new policy annotation policy.cozystack.io/allow-to-apiserver: "true" to update hook templates for both virtual machine and VM instance

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 21, 2025
Copy link
Contributor

coderabbitai bot commented Jan 21, 2025

Walkthrough

This pull request involves version updates and minor configuration changes across two packages: virtual-machine and vm-instance. The changes include incrementing chart and application versions from 0.7.0 to 0.7.1 for virtual-machine and from 0.4.0 to 0.4.1 for vm-instance. Additionally, a new policy annotation policy.cozystack.io/allow-to-apiserver: "true" has been added to the update hook templates for both packages, potentially modifying Job metadata permissions.

Changes

File Change Summary
packages/apps/versions_map Updated package versions for virtual-machine and vm-instance from HEAD to specific commit references
packages/apps/virtual-machine/Chart.yaml Version and appVersion incremented from 0.7.0 to 0.7.1
packages/apps/virtual-machine/templates/vm-update-hook.yaml Added annotation policy.cozystack.io/allow-to-apiserver: "true"
packages/apps/vm-instance/Chart.yaml Version and appVersion incremented from 0.4.0 to 0.4.1
packages/apps/vm-instance/templates/vm-update-hook.yaml Added annotation policy.cozystack.io/allow-to-apiserver: "true"

Possibly related PRs

Suggested labels

enhancement, size:L

Suggested reviewers

  • klinch0

Poem

🐰 Versions dance, a rabbit's delight,
Commits pinned with precision so bright,
Virtual machines hop and spin,
Annotations grant a new API grin,
Updating charts with playful might! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06afcf2 and 5db64e3.

📒 Files selected for processing (5)
  • packages/apps/versions_map (1 hunks)
  • packages/apps/virtual-machine/Chart.yaml (1 hunks)
  • packages/apps/virtual-machine/templates/vm-update-hook.yaml (1 hunks)
  • packages/apps/vm-instance/Chart.yaml (1 hunks)
  • packages/apps/vm-instance/templates/vm-update-hook.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • packages/apps/vm-instance/templates/vm-update-hook.yaml
  • packages/apps/vm-instance/Chart.yaml
  • packages/apps/virtual-machine/Chart.yaml
  • packages/apps/virtual-machine/templates/vm-update-hook.yaml
🔇 Additional comments (2)
packages/apps/versions_map (2)

111-112: LGTM: Version update for virtual-machine package.

The changes appropriately:

  • Pin version 0.7.0 to specific commit af58018
  • Introduce new version 0.7.1 for the API access policy changes

117-118: LGTM: Version update for vm-instance package.

The changes appropriately:

  • Pin version 0.4.0 to specific commit af58018
  • Introduce new version 0.4.1 for the API access policy changes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps kvaps requested a review from klinch0 January 23, 2025 15:38
@kvaps kvaps enabled auto-merge (squash) January 27, 2025 09:55
@kvaps kvaps disabled auto-merge January 27, 2025 09:55
@kvaps kvaps merged commit d557050 into main Jan 27, 2025
2 checks passed
@kvaps kvaps deleted the fix-vm-hook branch January 27, 2025 09:56
This was referenced Feb 11, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants