Fix VM services selector

[kvaps]

Signed-off-by: Andrei Kvapil kvapss@gmail.com

Summary by CodeRabbit

• Chores
  • Updated deployment configurations with the latest application versions (0.8.1 and 0.5.1) to ensure improved stability and compatibility.
• Bug Fixes
  • Enhanced service connectivity by refining the criteria used for routing requests to the correct application endpoints.

[coderabbitai]

Walkthrough

This pull request updates the version numbers and service selector configurations for two applications. In both the virtual-machine and vm-instance packages, the Chart.yaml files have been modified to increment the chart and app versions. Additionally, the corresponding service.yaml templates now reference updated selector labels, replacing the previous label inclusion. These changes adjust version management and service endpoint selection in the Helm chart configurations without altering other functionalities.

Changes

File(s)	Change Summary
packages/apps/virtual-machine/Chart.yaml packages/apps/vm-instance/Chart.yaml	Updated version and appVersion fields: from 0.8.0 to 0.8.1 (virtual-machine) and from 0.5.0 to 0.5.1 (vm-instance)
packages/apps/.../templates/service.yaml	Replaced the inclusion of virtual-machine.labels with virtual-machine.selectorLabels in the service selector configuration

Possibly related PRs

• Fix vm-update hook access to api #597: Updates similar versioning information in Chart.yaml files for the virtual-machine and vm-instance applications.

Suggested labels

lgtm

Suggested reviewers

• kvaps

Poem

I'm a hopping rabbit, quick on my feet,
Version bumps and label tweaks make the code complete.
Charts and selectors now shine so bright,
Guiding pods in the cluster with delight.
CodeRabbit's garden grows with each line—
A joyous sprint in every rhyme!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3fa4dd3 and 7986c3f.

📒 Files selected for processing (4)

• packages/apps/virtual-machine/Chart.yaml (1 hunks)
• packages/apps/virtual-machine/templates/service.yaml (1 hunks)
• packages/apps/vm-instance/Chart.yaml (1 hunks)
• packages/apps/vm-instance/templates/service.yaml (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• packages/apps/virtual-machine/Chart.yaml
• packages/apps/vm-instance/Chart.yaml

🧰 Additional context used

🪛 GitHub Actions: Pre-Commit Checks

packages/apps/vm-instance/templates/service.yaml

[error] 1-1: Error: ERROR: error getting current Parameters section from README

🔇 Additional comments (2)

packages/apps/vm-instance/templates/service.yaml (1)

17-18: LGTM! Improved pod selection precision.

The change from virtual-machine.labels to virtual-machine.selectorLabels aligns with Kubernetes best practices by using a more specific set of labels for pod selection, reducing the risk of unintended pod matches.

Let's verify that the helper template functions are properly defined:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Verify the existence of template helper functions

# Search for the template helper functions
rg -A 5 'virtual-machine\.selectorLabels' packages/apps/*/templates/_helpers.tpl

Length of output: 2069

---

Pod Selection Precision Helper Verified

The helper function virtual-machine.selectorLabels is properly defined in the vm-instance helper template (packages/apps/vm-instance/templates/_helpers.tpl), confirming that the update aligns with Kubernetes best practices.

packages/apps/virtual-machine/templates/service.yaml (1)

17-18: LGTM! Consistent selector update.

The selector change matches the update in vm-instance, maintaining consistency across services. This unified approach to pod selection is a good practice.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.