Skip to content

Commit

Permalink
Only create the connection closed exception once (#9405)
Browse files Browse the repository at this point in the history
  • Loading branch information
bdraco authored Oct 3, 2024
1 parent 3f43bd1 commit b96b01b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion aiohttp/client_reqrep.py
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,9 @@ async def _on_headers_request_sent(
await trace.send_request_headers(method, url, headers)


_CONNECTION_CLOSED_EXCEPTION = ClientConnectionError("Connection closed")


class ClientResponse(HeadersMixin):
# Some of these attributes are None when created,
# but will be set by the start() method.
Expand Down Expand Up @@ -1106,7 +1109,7 @@ def _notify_content(self) -> None:
content = self.content
# content can be None here, but the types are cheated elsewhere.
if content and content.exception() is None: # type: ignore[truthy-bool]
set_exception(content, ClientConnectionError("Connection closed"))
set_exception(content, _CONNECTION_CLOSED_EXCEPTION)
self._released = True

async def wait_for_close(self) -> None:
Expand Down

0 comments on commit b96b01b

Please # to comment.