-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Only create the connection closed exception once #9405
Conversation
Every connection will end with the connection closed exception. Only create it once since its always the same. related issue #4618
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9405 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 107 107
Lines 35037 35038 +1
Branches 4150 4150
=======================================
+ Hits 34536 34537 +1
Misses 334 334
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply b96b01b on top of patchback/backports/3.10/b96b01b13287608497497944c3a3148a75f8e6b1/pr-9405 Backporting merged PR #9405 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply b96b01b on top of patchback/backports/3.11/b96b01b13287608497497944c3a3148a75f8e6b1/pr-9405 Backporting merged PR #9405 into master
🤖 @patchback |
(cherry picked from commit b96b01b)
(cherry picked from commit b96b01b)
What do these changes do?
Every connection will end with the connection closed exception. Only create it once since its always the same.
related issue #4618 (comment)
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no