Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Http().terminate() which mimics Spray's CloseAll #188

Closed
ktoso opened this issue Sep 8, 2016 · 3 comments
Closed

Add Http().terminate() which mimics Spray's CloseAll #188

ktoso opened this issue Sep 8, 2016 · 3 comments
Assignees
@ktoso
Labels
t:core Issues related to the akka-http-core module
Milestone
10.1.2

Comments

@ktoso
Copy link
Contributor

ktoso commented Sep 8, 2016

Issue by ktoso
Tuesday Oct 06, 2015 at 10:13 GMT
Originally opened as akka/akka#18649

Implement a graceful shutdown which eventually closes connections (which is more than unbind does).

All details in the #18475 PR.
@ktoso ktoso added this to the http-backlog milestone Sep 8, 2016
@ktoso
Copy link
Contributor Author

ktoso commented Sep 8, 2016

Comment by ktoso
Thursday May 19, 2016 at 00:58 GMT

Triaged to mark I've gon through here, however we won't work on it - up for grabs

@ktoso
Copy link
Contributor Author

ktoso commented Sep 8, 2016

Comment by krzemin
Tuesday Jun 14, 2016 at 12:14 GMT

Hi, I'm interested in grabbing this. I assume that scope of the feature is basically what @sirthias wrote in akka/akka#18475 (comment). However I will need some guidance to get started.

Let's consider server-side part first. I expect that pools shutdown is not an option here. Instead, we have to rather unbind all listening sockets, and then wait for all connections being processed to finish. Could you explain in a bit more details how to achieve it?

@ktoso ktoso added the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Sep 8, 2016
@jonas jonas mentioned this issue Feb 28, 2017
Open
@ktoso ktoso mentioned this issue Jun 19, 2017
Closed
@ktoso
Copy link
Contributor Author

ktoso commented May 15, 2018

Note to self / us, that this has been requested again. Would be nice to get to it

@ktoso ktoso added the t:core Issues related to the akka-http-core module label May 15, 2018
@ktoso ktoso self-assigned this May 16, 2018
@ktoso ktoso added 3 - in progress Someone is working on this ticket and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels May 23, 2018
@ktoso ktoso modified the milestones: backlog, 10.1.2 May 23, 2018
@ktoso ktoso changed the title Add Http().gracefulShutdown() which mimics Spray's CloseAll Add Http().terminate() which mimics Spray's CloseAll May 29, 2018
@ktoso ktoso mentioned this issue May 29, 2018
Merged
ktoso added a commit to ktoso/akka-http that referenced this issue May 31, 2018
@ktoso
+htc graceful server termination support akka#188
2ecb01e
ktoso added a commit to ktoso/akka-http that referenced this issue May 31, 2018
@ktoso
+htc graceful server termination support akka#188
0b038da
ktoso added a commit to ktoso/akka-http that referenced this issue Jun 1, 2018
@ktoso
+htc graceful server termination support akka#188
54c38b6
ktoso added a commit that referenced this issue Jun 4, 2018
@ktoso
"Graceful" Server Termination #188 (#2035)
96605d0 
* +htc graceful server termination support #188

* fix typos

* review follow up, not using calling thread dispatcher anymore too

* remove todo
@ktoso ktoso removed the 3 - in progress Someone is working on this ticket label Jun 4, 2018
Falmarri pushed a commit to Falmarri/akka-http that referenced this issue Sep 26, 2018
@ktoso @Falmarri
"Graceful" Server Termination akka#188 (akka#2035)
da553d0 
* +htc graceful server termination support akka#188

* fix typos

* review follow up, not using calling thread dispatcher anymore too

* remove todo
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ktoso ktoso

Labels
t:core Issues related to the akka-http-core module
Projects
None yet
Milestone
10.1.2
Development

No branches or pull requests
1 participant
@ktoso