abort post-command on non-zero exit status

resolves buildkite-plugins#80 if the command (eg, bundle install) fails partway through, the cache plugin could upload a poisoned cache
amancevice · Oct 15, 2024 · c8287ae · c8287ae
1 parent d823b2e
commit c8287ae
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/hooks/post-command b/hooks/post-command
@@ -1,6 +1,12 @@
 #!/bin/bash
 set -euo pipefail
 
+# skip caching if command exited non-zero
+if [ $BUILDKITE_COMMAND_EXIT_STATUS -ne 0 ] ; then
+  echo "Aborting cache post-command hook because command exited with status $BUILDKITE_COMMAND_EXIT_STATUS"
+  exit 1
+fi
+
 DIR="$(cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd)"
 
 # shellcheck source=lib/shared.bash