Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Skip upload if step fails #80

Closed
amancevice opened this issue Oct 2, 2024 · 0 comments · Fixed by #84
Closed

Skip upload if step fails #80

amancevice opened this issue Oct 2, 2024 · 0 comments · Fixed by #84

Comments

@amancevice
Copy link
Contributor

I'm seeing an issue where a step fails partway through but the cache still uploads. This means that the subsequent retry step declines to upload the cache because it already found one. I think the plugin should skip uploading if the step doesn't exit cleanly.

Example configuration:

- cache#v1.1.0:
    backend: s3
    compression: tgz
    manifest: REVISION
    path: public/assets
    restore: file
    save: file
amancevice added a commit to amancevice/cache-buildkite-plugin that referenced this issue Oct 15, 2024
@amancevice
abort post-command on non-zero exit status
c8287ae 
resolves buildkite-plugins#80
if the command (eg, bundle install) fails partway through, the cache plugin could upload a poisoned cache
@amancevice amancevice mentioned this issue Oct 15, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

abort post-command on non-zero exit status amancevice/cache-buildkite-plugin
1 participant
@amancevice