SPI Engine: simplify interconnect #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBFFilho
force-pushed
the
spi_simple_interconnect
branch
4 times, most recently
from
555ec30 to
828c295
Compare
LBFFilho
force-pushed
the
spi_simple_interconnect
branch
from
828c295 to
491e2fd
Compare
LBFFilho
force-pushed
the
spi_simple_interconnect
branch
from
491e2fd to
0d23a2e
Compare
|
Tested with AD4052 |
LBFFilho
force-pushed
the
spi_simple_interconnect
branch
from
0d23a2e to
79cd8ea
Compare
LBFFilho
force-pushed
the
spi_simple_interconnect
branch
3 times, most recently
from
e04ecac to
f5ca16a
Compare
LBFFilho
requested review from
IuliaCMoldovan,
gastmaier,
StancaPop,
podgori,
ladace,
PIoandan,
PopPaul2021,
acostina and
AndreiGrozav
as code owners
LBFFilho
force-pushed
the
spi_simple_interconnect
branch
from
f5ca16a to
fd68eac
Compare
|
Updated for better timing, now to be merged after #1595 |
Make the interconnect use an external signal for switching between sources, so it becomes just a collection of muxes, reducing latency. This signal is generated based on the software-controlled offload enable, but is sourced from the offload module to avoid unnecessary CDCs. This commit makes the use of SYNC optional, unless the active signal from spi_engine_execution is needed. Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
LBFFilho
force-pushed
the
spi_simple_interconnect
branch
from
fd68eac to
dfdd65e
Compare
sarpadi
approved these changes
Mar 21, 2025
dlech
added a commit
to dlech/adi-hdl
that referenced
this pull request
Mar 31, 2025
Commit 24f2454 ("SPI Engine: simplify interconnect (analogdevicesinc#1502)") bumped the patch version in the documentation but missed changing it in PCORE_VERSION which is the value used by the version register. Signed-off-by: David Lechner <dlechner@baylibre.com>
13 tasks
dlech
added a commit
to dlech/adi-hdl
that referenced
this pull request
Mar 31, 2025
Commit 24f2454 ("SPI Engine: simplify interconnect (analogdevicesinc#1502)") made it so that the SYNC command is no longer required. This is actually a "feature" we want to test for. So that commit should have bumped the minor version instead of the patch version. Bump the version now so that we can test for this feature in the software driver. Signed-off-by: David Lechner <dlechner@baylibre.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Simplifies the interconnect logic, which is now just a set of muxes controlled by a signal from the offload module.
This makes the SYNC instructions optional, and reduces the trigger to first instruction latency.
Since it acts as a substitute for the offload module, axi_ad5766 had to be updated as well in order for it to provide the same interconnect control signal.
(This PR should be merged after #1501)
PR Type
PR Checklist