Skip to content

SPI Engine: fix transfers with echo_sclk #1595

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

SPI Engine: fix transfers with echo_sclk #1595

merged 2 commits into from
Mar 12, 2025

Conversation

LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Feb 28, 2025 •
edited
Loading

PR Description

This PR fixes echo_sclk transfers, which were broken for some cases. Notably, split transfers were problematic, affecting projects like the ad4630. Also fixes another issue where the first transfer would return 0.

tb: analogdevicesinc/testbenches#190

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@LBFFilho LBFFilho mentioned this pull request Feb 28, 2025
Draft
13 tasks
@LBFFilho LBFFilho requested a review from sarpadi February 28, 2025 19:47
@LBFFilho LBFFilho marked this pull request as ready for review March 3, 2025 12:33
@LBFFilho
Copy link
Contributor Author

LBFFilho commented Mar 5, 2025

RetriggerCI

@LBFFilho LBFFilho mentioned this pull request Mar 7, 2025
Merged
12 tasks
LBFFilho added 2 commits March 7, 2025 16:42
@LBFFilho
SPI Engine: fix segmented transfers with echo_sclk
3f3dfe9 
Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
@LBFFilho
library/spi_engine: pipeline last_bit_count, left_aligned
d857acb 
Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
@LBFFilho LBFFilho merged commit 3b0fd14 into main Mar 12, 2025
3 of 5 checks passed
@LBFFilho LBFFilho deleted the echo_sclk_fix branch March 12, 2025 12:24
ladace pushed a commit that referenced this pull request Mar 24, 2025
@LBFFilho @ladace
library/spi_engine: fix transfers with echo_sclk (#1595)
e23762b 
Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sarpadi sarpadi sarpadi approved these changes

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@podgori podgori Awaiting requested review from podgori podgori is a code owner

@ladace ladace Awaiting requested review from ladace ladace is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LBFFilho @sarpadi