-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci: test also cmake 3.10 #5
Conversation
According to github help ubuntu-latest is the same as ubuntu-18.04. Until they upgrade ubuntu-latest to 20.04 (which is still not known when) it means that CI will run twice on the same environment. Or am I missing something? Maybe simply lowering required cmake version without changing CI would be fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I had cmake --version
added in the configure step I can see that even for ubuntu-18.04 it still shows cmake version 3.17.0
so there is really no gain by running CI on ubuntu-18.04 before having 20.04 available here. Please update your pull request to only inlude change for CMakeLists.txt
and not .github/workflows/cmake.yml
I reverted the change in OS matrix, but added a cmake matrix item, to test 3 cmake versions.
Is there anything we can do to fix that, to improve support for older systems ? (my ubuntu 18.04 has cmake 3.10) |
For the record:
|
The error with cmake 3.10 is:
Would be nice to fix, but dunno when I'll have time to look at it - please keep this PR open if you don't plan to look at it yourself sooner |
I've rebased this PR against the "develop" branch. I saw your change only affected linux builds though, not Windows, so I guess the CI matrix should be changed accordingly, if things fail there... |
I know that windows build will fail with lower cmake versions but I don't have a windows machine to work on and it's a pain to develop for windows relying on github VM only (as you can see from commit history :)) |
27e454d
to
545823c
Compare
NOTE: does not test cmake < 3.15 on windows as it would fail
I've exluded windows with cmake < 3.15 from CI, linux and mac are still tested, and we're all happy :) |
I can't build because the cmake version on ubuntu-18.04 is 3.10.2.
This PR is to check if it's possible to build there, given enough
time :)