Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add deprecated tag to old version dubbo-rpc-thrift #2047

Merged
merged 3 commits into from
Jul 9, 2018
Merged

add deprecated tag to old version dubbo-rpc-thrift #2047

merged 3 commits into from
Jul 9, 2018

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Jul 8, 2018

What is the purpose of the change

add deprecated tag to old version dubbo-rpc-thrift, prepare to use https://github.com/dubbo/dubbo-rpc-native-thrift

Brief changelog

Make the dubbo-rpc-thrift deprecated

Verifying this change

CI pass

@lovepoem lovepoem changed the title deprecate old ali thrift add deprecated tag to old version dubbo-rpc-thrift Jul 8, 2018
@codecov-io
Copy link

codecov-io commented Jul 8, 2018

Codecov Report

Merging #2047 into master will increase coverage by 0.9%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #2047     +/-   ##
===========================================
+ Coverage     52.19%   53.09%   +0.9%     
+ Complexity     4963     4932     -31     
===========================================
  Files           568      557     -11     
  Lines         25453    24795    -658     
  Branches       4486     4426     -60     
===========================================
- Hits          13285    13165    -120     
+ Misses        10144     9612    -532     
+ Partials       2024     2018      -6
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/DubboShutdownHook.java 40% <0%> (-36%) 6% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-8.48%) 12% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 60% <0%> (-6.25%) 21% <0%> (-2%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 15% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (ø) 6% <0%> (ø) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 50% <0%> (+8.33%) 3% <0%> (ø) ⬇️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 69.23% <0%> (+15.38%) 3% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36a6ee...c2ddb3b. Read the comment docs.

@kimmking
Copy link
Member

kimmking commented Jul 9, 2018

I am updating this component, complete 75% now. @lovepoem

@chickenlj chickenlj merged commit 026693c into apache:master Jul 9, 2018
@lovepoem lovepoem deleted the wangxin_deprecate_old_ali_thrift branch July 9, 2018 08:31
July-X pushed a commit to July-X/dubbo that referenced this pull request Jul 12, 2018
* commit 'b055991b317f4e58d256721875a00c52fe415510': (271 commits)
  Merge pull request apache#1957, enhancements for the new async way of Dubbo.
  rename log file from alibaba to custom-access (apache#2057)
  Merge pull request apache#2049, upgrade netty4 to the latest release and make it the default option for transporter.
  Format style.
  Restore the badges in README.
  Polish README.
  Refactor README.
  Merge pull request apache#2047, deprecate dubbo-rpc-thrift.
  Merge pull request apache#2005, change maven parent from sonatype to apache.
  rename access log in unit test from 'alibaba' to 'alibaba.log' so that it cannot be committed by accident. (apache#2051)
  add test cases for injvm rpc protocol (apache#2041)
  add test cases for rpc thrift protocol (apache#2042)
  Merge pull request apache#1966, introduces dubbo metrics API module.
  [Dubbo- unit test class not found] fix class not found "hi" (apache#2034)
  add README for compatible module (apache#2019)
  Polish README.
  update README (apache#2025)
  [Dubbo-1695] Enhance the test coverage part-16 : dubbo-rpc/dubbo-rpc-api  module (apache#2004)
  Merge pull request apache#1997, clienthandler in netty4 should trigger heartbeat handler.
  Update issue template description.
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants