-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[dubbo-2029]: upgrade netty4 to the latest release and make it the default option for transporter #2049
Conversation
…option for transporter
Codecov Report
@@ Coverage Diff @@
## master #2049 +/- ##
============================================
+ Coverage 52.19% 53.02% +0.83%
- Complexity 4963 4986 +23
============================================
Files 568 568
Lines 25453 25460 +7
Branches 4486 4487 +1
============================================
+ Hits 13285 13501 +216
+ Misses 10144 9913 -231
- Partials 2024 2046 +22
Continue to review full report at Codecov.
|
Agree to change the default transporter to netty4. Only one thing to note: this change is not transparent to the user, they should guarantee |
To continue use based on your PR, add the following items, netty=org.apache.dubbo.remoting.transport.netty4.NettyTransporter
netty4=org.apache.dubbo.remoting.transport.netty4.NettyTransporter And netty3=org.apache.dubbo.remoting.transport.netty.NettyTransporter |
Keep @SPI("netty")
public interface Transporter { |
…option for transporter
Perhaps the |
@zonghaishang Agree to remove |
* commit 'b055991b317f4e58d256721875a00c52fe415510': (271 commits) Merge pull request apache#1957, enhancements for the new async way of Dubbo. rename log file from alibaba to custom-access (apache#2057) Merge pull request apache#2049, upgrade netty4 to the latest release and make it the default option for transporter. Format style. Restore the badges in README. Polish README. Refactor README. Merge pull request apache#2047, deprecate dubbo-rpc-thrift. Merge pull request apache#2005, change maven parent from sonatype to apache. rename access log in unit test from 'alibaba' to 'alibaba.log' so that it cannot be committed by accident. (apache#2051) add test cases for injvm rpc protocol (apache#2041) add test cases for rpc thrift protocol (apache#2042) Merge pull request apache#1966, introduces dubbo metrics API module. [Dubbo- unit test class not found] fix class not found "hi" (apache#2034) add README for compatible module (apache#2019) Polish README. update README (apache#2025) [Dubbo-1695] Enhance the test coverage part-16 : dubbo-rpc/dubbo-rpc-api module (apache#2004) Merge pull request apache#1997, clienthandler in netty4 should trigger heartbeat handler. Update issue template description. ...
…lt option for transporter
What is the purpose of the change
issue#2029: upgrade netty4 to the latest release and make it the default option for transporter
Brief changelog
dependencies-bom/pom.xml
dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java
dubbo-config/dubbo-config-api/pom.xml
dubbo-config/dubbo-config-spring/pom.xml
dubbo-demo/dubbo-demo-consumer/pom.xml
dubbo-demo/dubbo-demo-provider/pom.xml
dubbo-monitor/dubbo-monitor-default/pom.xml
dubbo-registry/dubbo-registry-default/pom.xml
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/Transporter.java
dubbo-remoting/dubbo-remoting-netty/src/test/java/org/apache/dubbo/remoting/exchange/support/header/HeartbeatHandlerTest.java
dubbo-remoting/dubbo-remoting-netty/src/test/java/org/apache/dubbo/remoting/transport/netty/ClientReconnectTest.java
dubbo-remoting/dubbo-remoting-netty/src/test/java/org/apache/dubbo/remoting/transport/netty/NettyClientTest.java
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClientHandler.java
dubbo-remoting/dubbo-remoting-p2p/pom.xml
dubbo-rpc/dubbo-rpc-dubbo/pom.xml
dubbo-rpc/dubbo-rpc-thrift/pom.xml
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.