HADOOP-19299. HttpReferrerAuditHeader resilience #7095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch all exceptions raised when building logger header log message at info; stack at debug Change-Id: I119abd167978dbc515554a36189462599870d1f9
|
🎊 +1 overall
This message was automatically generated. |
style checks + extra javadocs Change-Id: I1fbe381c49f51f9f4df62fd674a693c89ce9e9ed
|
tested s3 london. two failures from new tests which came with #7067 ; reopened that JIRA |
|
🎊 +1 overall
This message was automatically generated. |
zeekling
reviewed
Oct 4, 2024
...ct/hadoop-common/src/main/java/org/apache/hadoop/fs/store/audit/HttpReferrerAuditHeader.java
Show resolved
Hide resolved
| @@ -166,17 +179,18 @@ private HttpReferrerAuditHeader( | |||
| * per entry, and "" returned. | |||
| * @return a referrer string or "" | |||
| */ | |||
| public String buildHttpReferrer() { | |||
| public synchronized String buildHttpReferrer() { | |||
There was a problem hiding this comment.
That is the bug fix that has been found. Please see the jira for details. https://issues.apache.org/jira/browse/HADOOP-19299
mukund-thakur
approved these changes
Oct 4, 2024
steveloughran
commented
Oct 4, 2024
...ct/hadoop-common/src/main/java/org/apache/hadoop/fs/store/audit/HttpReferrerAuditHeader.java
Show resolved
Hide resolved
Change-Id: If7a1ff24de449be395667f550341389a5083097c
|
tested s3 london; only failures were those of #7098 |
|
🎊 +1 overall
This message was automatically generated. |
|
Build happy; merging and backporting |
Let's no flood the logs if there is a recurrent problem, ok? Change-Id: I189a5b9cb7c6d264bc4835a631e3da5ec3bb22de
|
🎊 +1 overall
This message was automatically generated. |
mukund-thakur
approved these changes
Oct 7, 2024
steveloughran
added a commit
that referenced
this pull request
Oct 7, 2024
* HttpReferrerAuditHeader is thread safe, copying the lists/maps passed in and using synchronized methods when necessary. * All exceptions raised when building referrer header are caught and swallowed. * The first such error is logged at warn, * all errors plus stack are logged at debug Contributed by Steve Loughran
asfgit
pushed a commit
that referenced
this pull request
Oct 7, 2024
* HttpReferrerAuditHeader is thread safe, copying the lists/maps passed in and using synchronized methods when necessary. * All exceptions raised when building referrer header are caught and swallowed. * The first such error is logged at warn, * all errors plus stack are logged at debug Contributed by Steve Loughran
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-19299
Catch all exceptions raised when building logger header log message at info; stack at debug
How was this patch tested?
new unit test
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?