Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(bindings/nodejs): Fix index.d.ts not updated #2117

Merged
merged 2 commits into from
Apr 25, 2023
Merged

fix(bindings/nodejs): Fix index.d.ts not updated #2117

merged 2 commits into from
Apr 25, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 25, 2023

This PR will fix outdated d.ts and add a CI task to prevent it.

Xuanwo added 2 commits April 25, 2023 19:47
@Xuanwo
fix(bindings/nodejs): Fix index.d.ts not updated
ae848ce 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Make add check
4dd8e2c 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit d6ce049 into main Apr 25, 2023
@Xuanwo Xuanwo deleted the fix-index-d.ts-not-updated branch April 25, 2023 11:53
@Xuanwo Xuanwo mentioned this pull request Apr 25, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx