Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(bindings/nodejs): Fix index.d.ts not updated #2117

Merged
merged 2 commits into from
Apr 25, 2023
Merged

fix(bindings/nodejs): Fix index.d.ts not updated #2117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae848ce
fix(bindings/nodejs): Fix index.d.ts not updated
Xuanwo Apr 25, 2023
4dd8e2c
Make add check
Xuanwo Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/bindings_nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ jobs:

- name: Build
run: yarn build:debug

- name: Check diff
run: git diff --exit-code

- name: Test bindings
run: yarn test

Expand Down
18 changes: 11 additions & 7 deletions bindings/nodejs/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,14 +336,14 @@ export class Operator {
* ### Example
*
* ```javascript
* const req = op.presignRead(path, parseInt(expires));
* const req = await op.presignRead(path, parseInt(expires));
*
* console.log("method: ", req.method);
* console.log("url: ", req.url);
* console.log("headers: ", req.headers);
* ```
*/
presignRead(path: string, expires: number): PresignedRequest
presignRead(path: string, expires: number): Promise<PresignedRequest>
/**
* Get a presigned request for write.
*
Expand All @@ -352,14 +352,14 @@ export class Operator {
* ### Example
*
* ```javascript
* const req = op.presignWrite(path, parseInt(expires));
* const req = await op.presignWrite(path, parseInt(expires));
*
* console.log("method: ", req.method);
* console.log("url: ", req.url);
* console.log("headers: ", req.headers);
* ```
*/
presignWrite(path: string, expires: number): PresignedRequest
presignWrite(path: string, expires: number): Promise<PresignedRequest>
/**
* Get a presigned request for stat.
*
Expand All @@ -368,14 +368,14 @@ export class Operator {
* ### Example
*
* ```javascript
* const req = op.presignStat(path, parseInt(expires));
* const req = await op.presignStat(path, parseInt(expires));
*
* console.log("method: ", req.method);
* console.log("url: ", req.url);
* console.log("headers: ", req.headers);
* ```
*/
presignStat(path: string, expires: number): PresignedRequest
presignStat(path: string, expires: number): Promise<PresignedRequest>
}
export class Entry {
/** Return the path of this entry. */
Expand All @@ -396,7 +396,11 @@ export class Metadata {
get contentType(): string | null
/** ETag of this object. */
get etag(): string | null
/** Last Modified of this object.(UTC) */
/**
* Last Modified of this object.
*
* We will output this time in RFC3339 format like `1996-12-19T16:39:57+08:00`.
*/
get lastModified(): string | null
}
export class Lister {
Expand Down