Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(services/core): Implement stat_has_* and list_has_* correctly for services #5472

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

geetanshjuneja
Copy link
Contributor

@geetanshjuneja geetanshjuneja commented Dec 28, 2024

Which issue does this PR close?

Closes #5314.

Rationale for this change

What changes are included in this PR?

Implemented stat_has_* and list_has_* correctly for services
I have removed some redundant code mentioned below

if let Some(size) = content.size {
md.set_content_length(size);
}

if let Some(size) = content.size {
md.set_content_length(size);
}

Are there any user-facing changes?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @geetanshjuneja for getting this fixed!

@Xuanwo Xuanwo merged commit 4e99afa into apache:main Dec 30, 2024
162 checks passed
@geetanshjuneja geetanshjuneja deleted the capability_flags branch December 30, 2024 12:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issues of RFC-5313: Remove Metakey
2 participants