Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(services/ghac): Fix stat_with_if_none_match been set in wrong #5477

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 30, 2024

Which issue does this PR close?

Fix CI failure introduced by #5472

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Xuanwo Xuanwo merged commit 52c96bb into main Dec 30, 2024
92 checks passed
@Xuanwo Xuanwo deleted the fix-ghac branch December 30, 2024 04:54
Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #5477 will degrade performances by 15.89%

Comparing fix-ghac (1c21cf1) with main (4e99afa)

Summary

⚡ 8 improvements
❌ 4 regressions
✅ 61 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-ghac Change
buffer 256 KiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 256 KiB * 4 chunk 154.4 ns 183.6 ns -15.89%
buffer 4.00 MiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 4.00 MiB * 4 chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 1000k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 1000k truncate 245.8 ns 216.7 ns +13.46%
256 KiB * 100k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 100k truncate 245.8 ns 216.7 ns +13.46%
256 KiB * 10k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 10k truncate 245.8 ns 216.7 ns +13.46%
256 KiB * 1k chunk 212.8 ns 183.6 ns +15.89%
256 KiB * 1k truncate 245.8 ns 216.7 ns +13.46%

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants