-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][txn]Fix TopicTransactionBuffer potential thread safety issue #22149
Merged
dao-jun
merged 4 commits into
apache:master
from
dao-jun:fix/topictxnbuffer_thread_safe
Feb 29, 2024
Merged
[fix][txn]Fix TopicTransactionBuffer potential thread safety issue #22149
dao-jun
merged 4 commits into
apache:master
from
dao-jun:fix/topictxnbuffer_thread_safe
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lhotari
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 4, 2024
…pache#22149) (cherry picked from commit 74be3fd) (cherry picked from commit c6b4887)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…pache#22149) (cherry picked from commit 74be3fd) (cherry picked from commit c6b4887)
Technoboy-
pushed a commit
that referenced
this pull request
Mar 13, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
area/transaction
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.3
release/3.1.3
release/3.2.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22119
PIP: #xyz
Motivation
Fix TopicTransactionBuffer potential thread safety issue.
Modifications
Make all the read/write operations of
TopicTransactionBuffer#ongoingTxns
insync
scope.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: dao-jun#7