Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][txn]Fix TopicTransactionBuffer potential thread safety issue #22149

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Feb 28, 2024

Fixes #22119

PIP: #xyz

Motivation

Fix TopicTransactionBuffer potential thread safety issue.

Modifications

Make all the read/write operations of TopicTransactionBuffer#ongoingTxns in sync scope.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dao-jun#7

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dao-jun dao-jun merged commit 74be3fd into apache:master Feb 29, 2024
51 checks passed
heesung-sn pushed a commit that referenced this pull request Feb 29, 2024
gaoran10 pushed a commit that referenced this pull request Mar 4, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 4, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
@dao-jun dao-jun deleted the fix/topictxnbuffer_thread_safe branch May 3, 2024 00:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TopicTransactionBuffer contains potential thread safety issues
4 participants