Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][broker] Add fine-grain authorization to retention admin API #22163

Merged

Conversation

mattisonchao
Copy link
Member

Motivation

Add fine-grain authorization to retention admin API so that it can be controlled at a more fine-grain level.

Modifications

  • Update getRetention, add PolicyName.RETENTION with READ check
  • Update setRetention & removeRetention, add PolicyName.RETENTION with WRITE check

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

  • The REST endpoints

Documentation

  • doc-not-needed

Add fine-grain authorization to retention admin API so that it can be controlled at a more fine-grain level.

- Update getRetention, add PolicyName.RETENTION with READ check
- Update setRetention & removeRetention, add PolicyName.RETENTION with WRITE check
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work @mattisonchao

@Technoboy- Technoboy- merged commit 6ec473e into apache:master Feb 29, 2024
52 of 53 checks passed
@heesung-sn
Copy link
Contributor

@mattisonchao We have a conflict in branch-3.0. can you help to cherry-pick this to branch-3.0?

mattisonchao added a commit that referenced this pull request Mar 4, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 4, 2024
mattisonchao added a commit that referenced this pull request Mar 4, 2024
mattisonchao added a commit that referenced this pull request Mar 4, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
(cherry picked from commit 4b5dba7)
nikhil-ctds added a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
(cherry picked from commit 4b5dba7)
nikhil-ctds added a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants