Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][fn] Add configuration for connector & functions package url sources #22184

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 4, 2024

Motivation

Currently the configuration is missing for enabling and disabling connector and function package url sources.

Modifications

  • Add configuration for enabling connector and functions package urls in functions_worker.yml

  • Add checking of package urls in required locations in Function Worker code

  • doc

  • doc-required

  • doc-not-needed

  • doc-complete

Copy link

github-actions bot commented Mar 4, 2024

@lhotari Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@Technoboy- Technoboy- closed this Mar 4, 2024
@Technoboy- Technoboy- reopened this Mar 4, 2024
@Technoboy- Technoboy- added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 4, 2024
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Technoboy- Technoboy- force-pushed the lh-add-config-for-package-sources branch from b88585c to 9bb3dcc Compare March 4, 2024 14:39
@gaoran10 gaoran10 merged commit 207335a into apache:master Mar 4, 2024
50 checks passed
gaoran10 pushed a commit that referenced this pull request Mar 4, 2024
lhotari added a commit that referenced this pull request Mar 4, 2024
lhotari added a commit that referenced this pull request Mar 4, 2024
lhotari added a commit that referenced this pull request Mar 4, 2024
… sources (#22184)

(cherry picked from commit 207335a)
(cherry picked from commit b107387)
lhotari added a commit that referenced this pull request Mar 4, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 5, 2024
… sources (apache#22184)

(cherry picked from commit 207335a)
(cherry picked from commit b183492)
mukesh-ctds added a commit to datastax/pulsar that referenced this pull request Mar 5, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
… sources (apache#22184)

(cherry picked from commit 207335a)
(cherry picked from commit b183492)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
… sources (apache#22184)

(cherry picked from commit 207335a)
(cherry picked from commit b183492)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
… sources (apache#22184)

(cherry picked from commit 207335a)
(cherry picked from commit b107387)
(cherry picked from commit b83dab5)

 Conflicts:
	pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java
	pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java
	pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
	pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionActionerTest.java
nikhil-ctds added a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
… sources (apache#22184)

(cherry picked from commit 207335a)
(cherry picked from commit b107387)
(cherry picked from commit b83dab5)

 Conflicts:
	pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java
	pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java
	pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
	pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionActionerTest.java
nikhil-ctds added a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants