Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][cli] PIP-343: Use picocli instead of jcommander in bin/pulsar #22288

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Mar 18, 2024

PIP: #22181

Motivation

Improve CLI user experience.

Modifications

  • Use picocli instead of jcommander in bin/pulsar
    • Only refactor the pulsar command
  • Fix some tests about generating document

Verifying this change

  • Make sure that the change passes the CI checks.

Relying on existing tests for validation.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 18, 2024
@nodece nodece requested review from Technoboy- and dao-jun March 18, 2024 07:34
@nodece nodece added this to the 3.3.0 milestone Mar 18, 2024
@nodece nodece self-assigned this Mar 18, 2024
@Technoboy- Technoboy- closed this Mar 19, 2024
@Technoboy- Technoboy- reopened this Mar 19, 2024
@nodece nodece force-pushed the pip-343-pulsar-cli branch 3 times, most recently from b12f447 to 39bbbdb Compare March 19, 2024 15:17
@nodece nodece force-pushed the pip-343-pulsar-cli branch from 39bbbdb to 36be27e Compare March 20, 2024 04:17
@nodece
Copy link
Member Author

nodece commented Mar 20, 2024

/pulsarbot rerun-failure-checks

Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need more reviewers for this.
Could you help review @lhotari @poorbarcode .

@nodece nodece merged commit 7644a02 into apache:master Mar 22, 2024
48 of 50 checks passed
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/cli doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants