Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][pip] PIP-343: Use picocli instead of jcommander #22181

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Mar 3, 2024

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Due to the large scope of refactoring, I need to split the PR:

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added type/PIP doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Mar 3, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@crossoverJie
Copy link
Member

When #22209 is merged, I apply to refactor pulsar-perf module

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece added this to the 3.3.0 milestone Mar 7, 2024
@nodece nodece merged commit 63c0b47 into apache:master Mar 14, 2024
20 checks passed
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants