[improve][cli] PIP-343: Use picocli instead of jcommander in pulsar-perf #22303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodece PTAL |
nodece
reviewed
Mar 19, 2024
pulsar-cli-utils/src/main/java/org/apache/pulsar/cli/converters/ByteUnitToLongConverter.java
Outdated
Show resolved
Hide resolved
nodece
requested changes
Mar 19, 2024
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/CmdGenerateDocumentation.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/CmdGenerateDocumentation.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/CmdGenerateDocumentation.java
Outdated
Show resolved
Hide resolved
...ar-testclient/src/main/java/org/apache/pulsar/testclient/PositiveNumberParameterConvert.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceTransaction.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/LoadSimulationController.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/LoadSimulationController.java
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/LoadSimulationClient.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/CmdGenerateDocumentation.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/BrokerMonitor.java
Show resolved
Hide resolved
…mdGenerateDocumentation.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…ositiveNumberParameterConvert.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceTransaction.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceReader.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceConsumer.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…anagedLedgerWriter.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
nodece
reviewed
Mar 20, 2024
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/CmdGenerateDocumentation.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot rerun-failure-checks |
Technoboy-
approved these changes
Mar 22, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…erf (apache#22303) Co-authored-by: Zixuan Liu <nodeces@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #22181
Improve CLI:
pulsar-perfuser experience.Motivation
Modifications
pulsar-perfcode.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: crossoverJie#21