Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cleanup][cli] Cleanup jcommander #22337

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

nodece
Copy link
Member

@nodece nodece commented Mar 25, 2024

Motivation

#22181 has been done, we can remove the jcommander from codebase.

Modifications

  • Remove unuse class
  • Remove jcommander library
  • Use IllegalArgumentException instead of ParameterException

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 25, 2024
@nodece nodece force-pushed the clenaup-jcommander branch from 65bbcb6 to 54d0364 Compare March 25, 2024 08:30
@nodece nodece self-assigned this Mar 25, 2024
@nodece
Copy link
Member Author

nodece commented Mar 25, 2024

/pulsarbot rerun-failure-checks

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the clenaup-jcommander branch from 54d0364 to 696c44c Compare March 25, 2024 11:35
@Technoboy- Technoboy- added this to the 3.3.0 milestone Mar 27, 2024
@Technoboy- Technoboy- merged commit d23a8f6 into apache:master Mar 27, 2024
49 of 50 checks passed
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Apr 1, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/cli doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants