Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest #23456

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest #23456

merged 2 commits into from
Oct 14, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 14, 2024 •
edited
Loading

Fixes #23455

Motivation

GetPartitionMetadataMultiBrokerTest.testCompatibilityForNewClientAndOldBroker is really flaky and fails often.
There's an explanation for the flakiness, it's similar as #23259.

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone Oct 14, 2024
@lhotari lhotari requested a review from poorbarcode October 14, 2024 08:39
@lhotari lhotari self-assigned this Oct 14, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 14, 2024
@lhotari lhotari requested a review from BewareMyPower October 14, 2024 08:44
@lhotari lhotari changed the title [fix][test] Address flaky GetPartitionMetadataMultiBrokerTest with retries in CI [fix][test] Address flaky GetPartitionMetadataMultiBrokerTest Oct 14, 2024
@lhotari lhotari requested a review from Technoboy- October 14, 2024 08:46
@Technoboy- Technoboy- merged commit 0c4108b into apache:master Oct 14, 2024
56 of 57 checks passed
@lhotari lhotari modified the milestones: 4.1.0, 4.0.0 Oct 14, 2024
lhotari added a commit that referenced this pull request Oct 14, 2024
@lhotari
[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest (#23456)
26cbc25 
(cherry picked from commit 0c4108b)
lhotari added a commit that referenced this pull request Oct 14, 2024
@lhotari
[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest (#23456)
fc78357 
(cherry picked from commit 0c4108b)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 15, 2024
@lhotari @nikhil-ctds
[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest (apache…
32daf83 
…#23456)

(cherry picked from commit 0c4108b)
(cherry picked from commit 26cbc25)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 16, 2024
@lhotari @srinath-ctds
[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest (apache…
ac15753 
…#23456)

(cherry picked from commit 0c4108b)
(cherry picked from commit 26cbc25)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@lhotari @hanmz
[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest (apache…
0ebe4ee 
…#23456)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

Assignees

@lhotari lhotari

Labels
cherry-picked/branch-3.0 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.8 release/3.3.3 release/4.0.0
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Flaky-test: GetPartitionMetadataMultiBrokerTest.testCompatibilityForNewClientAndOldBroker
4 participants
@lhotari @Technoboy- @BewareMyPower @poorbarcode