Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest #23456

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest #23456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1952d87
[fix][test] Address flaky GetPartitionMetadataMultiBrokerTest with re…
lhotari Oct 14, 2024
ac3354d
Fix flakiness issue
lhotari Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/GetPartitionMetadataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import org.apache.pulsar.common.policies.data.TenantInfoImpl;
import org.apache.pulsar.common.policies.data.TopicType;
import org.apache.pulsar.common.util.FutureUtil;
import org.apache.pulsar.tests.TestRetrySupport;
import org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble;
import org.awaitility.Awaitility;
import org.testng.annotations.AfterClass;
Expand All @@ -56,7 +57,7 @@

@Test(groups = "broker-admin")
@Slf4j
public class GetPartitionMetadataTest {
public class GetPartitionMetadataTest extends TestRetrySupport {

protected static final String DEFAULT_NS = "public/default";

Expand All @@ -72,8 +73,10 @@ public class GetPartitionMetadataTest {
protected PulsarClientImpl clientWithHttpLookup1;
protected PulsarClientImpl clientWitBinaryLookup1;

@Override
@BeforeClass(alwaysRun = true)
protected void setup() throws Exception {
incrementSetupNumber();
bkEnsemble = new LocalBookkeeperEnsemble(3, 0, () -> 0);
bkEnsemble.start();
// Start broker.
Expand All @@ -85,8 +88,10 @@ protected void setup() throws Exception {
admin1.namespaces().createNamespace(DEFAULT_NS);
}

@Override
@AfterClass(alwaysRun = true)
protected void cleanup() throws Exception {
markCurrentSetupNumberCleaned();
cleanupBrokers();
if (bkEnsemble != null) {
bkEnsemble.stop();
Expand Down Expand Up @@ -236,7 +241,7 @@ public void testCompatibilityForNewClientAndOldBroker(TopicDomain topicDomain) t
String pulsarUrl = pulsar1.getBrokerServiceUrl();
PulsarClientImpl[] clients = getClientsToTest(false);
for (PulsarClientImpl client : clients) {
client.getLookup(pulsarUrl).getBroker(TopicName.get(DEFAULT_NS + "/tp1"));
client.getLookup(pulsarUrl).getBroker(TopicName.get(DEFAULT_NS + "/tp1")).join();
}
// Inject a not support flag into the connections initialized.
Field field = ClientCnx.class.getDeclaredField("supportsGetPartitionedMetadataWithoutAutoCreation");
Expand Down
Loading