This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
Switch Dredd to CircleCI #1494
Merged
Switch Dredd to CircleCI #1494
+156
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CircleCI sets NO_PROXY by default which affects the tests.
honzajavorek
force-pushed
the
honzajavorek/circleci
branch
from
e37e681 to
fbf1a33
Compare
This was referenced Sep 13, 2019
honzajavorek
requested review from
a team
and removed request for
artem-zakharchenko
kylef
reviewed
Sep 13, 2019
There was a problem hiding this comment.
@kylef's suggestions are valid, none additional from me. Finally CircleCI 🎉
honzajavorek
force-pushed
the
honzajavorek/circleci
branch
from
6086de7 to
9f6a074
Compare
kylef
approved these changes
Sep 16, 2019
|
🎉 This PR is included in version 12.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Why this change?
Checking a box from #1186. We wanted to do this for a long time already. Makes it easier to turn Dredd into a monorepo.
📝 Related issues and Pull Requests
Documented in #1186, enables #784 and #704.
✅ What didn't I forget?
npm run lint