Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Use Node 12 in AppVeyor #1495

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Conversation

honzajavorek
Copy link
Contributor

πŸš€ Why this change?

We always use the latest Node version we support when testing on AppVeyor. We added Node 12 to the other CI, but didn't switch AppVeyor to use it.

βœ… What didn't I forget?

  • To write docs
  • To write tests
  • To put Conventional Changelog prefixes in front of all my commits and run npm run lint

@honzajavorek honzajavorek requested a review from a team September 13, 2019 16:22
@honzajavorek
Copy link
Contributor Author

Won't pass until #1494 is merged.

@honzajavorek honzajavorek force-pushed the honzajavorek/fix-node-appveyor branch from 64a9c64 to a84a2bb Compare September 16, 2019 11:23
Copy link
Contributor

@artem-zakharchenko artem-zakharchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@honzajavorek honzajavorek merged commit 2604c7e into master Oct 1, 2019
@honzajavorek honzajavorek mentioned this pull request Oct 1, 2019
3 tasks
@ApiaryBot
Copy link
Collaborator

πŸŽ‰ This PR is included in version 12.1.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@artem-zakharchenko artem-zakharchenko deleted the honzajavorek/fix-node-appveyor branch October 3, 2019 12:29
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants