Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update expired test certificate #482

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Update expired test certificate #482

merged 1 commit into from
Oct 3, 2024

Conversation

rnro
Copy link
Contributor

@rnro rnro commented Oct 1, 2024

Update expired test certificate.

Motivation:

An expired test certificate was causing tests to fail.

Modifications:

Updated the test certificate.

Result:

Tests should pass.

Motivation:

An expired test certificate was causing tests to fail.

Modifications:

Updated the test certificate.

Result:

Tests should pass.
@Lukasa Lukasa added the semver/none No version bump required. label Oct 1, 2024
@rnro
Copy link
Contributor Author

rnro commented Oct 1, 2024

PR validation fails with malloc leak issues on 5.8, 5.9, 5.10

09:00:36 ++ not_freed_allocations=8000
09:00:36 ++ max_allowed_env_name=MAX_ALLOCS_ALLOWED_simple_handshake
09:00:36 ++ info 'simple_handshake: allocations not freed: 8000'
09:00:36 ++ true
09:00:36 ++ true
09:00:36 ++ echo 'info: simple_handshake: allocations not freed: 8000'
09:00:36 ++ info 'simple_handshake: total number of mallocs: 629480'
09:00:36 ++ true
09:00:36 ++ true
09:00:36 ++ echo 'info: simple_handshake: total number of mallocs: 629480'
09:00:36 ++ assert_less_than 8000 5
09:00:36 ++ [[ ! 8000 -lt 5 ]]
09:00:36 ++ fail 'assertion '\''8000'\'' < '\''5'\'' failed'
09:00:36 ++ echo 'FAILURE: assertion '\''8000'\'' < '\''5'\'' failed'
09:00:36 FAILURE: assertion '8000' < '5' failed

@rnro
Copy link
Contributor Author

rnro commented Oct 2, 2024

@swift-server-bot test this please

@rnro
Copy link
Contributor Author

rnro commented Oct 2, 2024

PR validation fails with malloc leak issues on 5.8, 5.9, 5.10

09:00:36 ++ not_freed_allocations=8000
09:00:36 ++ max_allowed_env_name=MAX_ALLOCS_ALLOWED_simple_handshake
09:00:36 ++ info 'simple_handshake: allocations not freed: 8000'
09:00:36 ++ true
09:00:36 ++ true
09:00:36 ++ echo 'info: simple_handshake: allocations not freed: 8000'
09:00:36 ++ info 'simple_handshake: total number of mallocs: 629480'
09:00:36 ++ true
09:00:36 ++ true
09:00:36 ++ echo 'info: simple_handshake: total number of mallocs: 629480'
09:00:36 ++ assert_less_than 8000 5
09:00:36 ++ [[ ! 8000 -lt 5 ]]
09:00:36 ++ fail 'assertion '\''8000'\'' < '\''5'\'' failed'
09:00:36 ++ echo 'FAILURE: assertion '\''8000'\'' < '\''5'\'' failed'
09:00:36 FAILURE: assertion '8000' < '5' failed

This was a NIO issue and resolved there apple/swift-nio#2901

@rnro
Copy link
Contributor Author

rnro commented Oct 2, 2024

@swift-server-bot test this please

1 similar comment
@rnro
Copy link
Contributor Author

rnro commented Oct 3, 2024

@swift-server-bot test this please

@rnro rnro merged commit aa68d49 into apple:main Oct 3, 2024
8 of 9 checks passed
@rnro rnro deleted the update_test_cert branch October 3, 2024 07:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants