ConditionLock deallocs its pthread_cond_t in more cases #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Recently we changed the init and deinit behavior of `ConditionLock`, at that time the `UnsafeMutablePointer` allocation of the held `pthread_cond_t` was put behind a conditional compiler and runtime check. The deallocation of the same object was also put behind a conditional, however the conditions were mismatched leading to a leak on some platforms. Notably this surfaced when `wait`ing on an event loop future. Modifications: `ConditionLock.deinit` now deallocs the held `pthread_cond_t` under the same conditions in which it allocs it. Result: Creating a `ConditionLock` no longer leaks memory.
rnro
force-pushed
the
ConditionLock_leak
branch
from
4d94a44 to
3f65c08
Compare
rnro
added
🆕 semver/minor
MaxDesiatov
approved these changes
Oct 2, 2024
Lukasa
approved these changes
Oct 2, 2024
|
Worth considering whether we should add a regression benchmark test for this. |
This was referenced Oct 2, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Recently we changed the init and deinit behavior of
ConditionLock, at that time theUnsafeMutablePointerallocation of the heldpthread_cond_twas put behind a conditional compiler and runtime check. The deallocation of the same object was also put behind a conditional, however the conditions were mismatched leading to a leak on some platforms. Notably this surfaced whenwaiting on an event loop future.Modifications:
ConditionLock.deinitnow deallocs the heldpthread_cond_tunder the same conditions in which it allocs it.Result:
Creating a
ConditionLockno longer leaks memory.