Add support for automatic HTTP error reporting. #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
force-pushed
the
cb-fix-integration-tests
branch
from
265104a to
3f06fc1
Compare
|
CC'ing @tanner0101 because they probably want to use the |
Lukasa
force-pushed
the
cb-fix-integration-tests
branch
from
3f06fc1 to
2b70cb4
Compare
|
@Lukasa hmm, this hit looks like we have a race in that test, this shouldn't be related to your changes AFAIK |
|
@swift-nio-bot test this please |
Lukasa
force-pushed
the
cb-fix-integration-tests
branch
from
2b70cb4 to
48e833f
Compare
Motivation: Currently the HTTP decoders can throw errors, but they will be ignored and lead to a simple EOF. That's not ideal: in most cases we should make a best-effort attempt to send a 4XX error code before we shut the client down. Modifications: Provided a new ChannelHandler that generates 400 errors when the HTTP decoder fails. Added a flag to automatically add that handler to the channel pipeline. Added the handler to the HTTP sample server. Enabled integration test 12. Result: Easier error handling for HTTP servers.
Lukasa
force-pushed
the
cb-fix-integration-tests
branch
from
48e833f to
bc7e1c8
Compare
normanmaurer
reviewed
Apr 4, 2018
| let headers = HTTPHeaders([("Connection", "close"), ("Content-Length", "0")]) | ||
| let head = HTTPResponseHead(version: .init(major: 1, minor: 1), status: .badRequest, headers: headers) | ||
| ctx.write(self.wrapOutboundOut(.head(head)), promise: nil) | ||
| ctx.writeAndFlush(self.wrapOutboundOut(.end(nil)), promise: nil) |
There was a problem hiding this comment.
@Lukasa should we also attach a callback to the future which closes the channel once written ?
There was a problem hiding this comment.
No. Any of these errors will cause a channel to be closed by the HTTPDecoder, so I don't think it's required.
normanmaurer
reviewed
Apr 4, 2018
| // A side note here: we cannot block or do any delayed work. ByteToMessageDecoder is going | ||
| // to come along and close the channel right after we return from this function. | ||
| let headers = HTTPHeaders([("Connection", "close"), ("Content-Length", "0")]) | ||
| let head = HTTPResponseHead(version: .init(major: 1, minor: 1), status: .badRequest, headers: headers) |
There was a problem hiding this comment.
is 1 .1 a good choice here or should we use 1.0 ?
There was a problem hiding this comment.
What value do we obtain by using 1.0?
There was a problem hiding this comment.
Was just wondering if 1.0 would be a better choice but I guess 1.1 is more used these days so all good
|
@swift-nio-bot test this please |
|
@Lukasa @weissi leak detector tripped @swift-nio-bot test this please |
|
@normanmaurer Please re-review. |
normanmaurer
approved these changes
Apr 7, 2018
|
@Lukasa thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently the HTTP decoders can throw errors, but they will be ignored
and lead to a simple EOF. That's not ideal: in most cases we should make
a best-effort attempt to send a 4XX error code before we shut the client
down.
Modifications:
Provided a new ChannelHandler that generates 400 errors when the HTTP
decoder fails.
Added a flag to automatically add that handler to the channel pipeline.
Added the handler to the HTTP sample server.
Enabled integration test 12.
Result:
Easier error handling for HTTP servers.