Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

HTTPServer should use withPipeliningAssistance (and when merged withErrorReporting) #255

Closed
weissi opened this issue Apr 3, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@weissi
Copy link

weissi commented Apr 3, 2018

Right now the HTTP pipeline is configured this way:

channel.pipeline.configureHTTPServerPipeline(withServerUpgrade: upgrade)

that sets up an upgrade handler 👍 but doesn't use pipelining assistance (enabled with withPipeliningAssistance: true (available since NIO 1.2.0) not error reporting (enabled with withErrorReporting: true (will be in NIO 1.4.0, PR here)).

  • the downside of not using pipelining assistance is that it's pretty hard to work correctly with HTTP pipelining if the withPipeliningAssistance: true isn't used
  • the downside of not using automatic error reporting is that if an error like 'headers too large' appears the connection is just closed without sending a response (400 BAD REQUEST) back.

(we can't really enable those options by default because that'd be SemVer breaking ...)

@tanner0101 tanner0101 added this to the 3.0.0 milestone Apr 17, 2018
@tanner0101 tanner0101 added the enhancement New feature or request label Apr 17, 2018
@tanner0101 tanner0101 self-assigned this Apr 17, 2018
tanner0101 added a commit that referenced this issue Apr 17, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants