alloc tests: hook posix_memalign & reallocf #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Swift started using posix_memalign very recently (Jan 2019) so we need to hook that too to get correct results. Modifications: Hook posix_memalign, reallocf & valloc Result: alloc tests should pass again
weissi
force-pushed
the
jw-fix-memtests
branch
from
0ba18d6 to
065d455
Compare
Lukasa
approved these changes
Jan 25, 2019
weissi
added a commit
that referenced
this pull request
Jan 25, 2019
Motivation: Newer Swift versions are good and we should test them, this one threw a few curveballs at us: - started using `posix_memalign` which needed fixing in our alloc tests (fixed in #782) - the optimiser decided not to inline a function that needs to be inlined Modifications - `@inline(__always)` to help the optimiser - update Swift version Result: - fixes #727 - fixes #726
weissi
added a commit
to weissi/swift-nio
that referenced
this pull request
Apr 8, 2019
Motivation: Swift started using posix_memalign very recently (Jan 2019) so we need to hook that too to get correct results. Modifications: Hook posix_memalign, reallocf & valloc Result: alloc tests should pass again (cherry picked from commit de8d3e2)
weissi
added a commit
that referenced
this pull request
Apr 8, 2019
Motivation: Swift started using posix_memalign very recently (Jan 2019) so we need to hook that too to get correct results. Modifications: Hook posix_memalign, reallocf & valloc Result: alloc tests should pass again (cherry picked from commit de8d3e2)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift started using posix_memalign very recently (Jan 2019) so we need
to hook that too to get correct results.
Modifications:
Hook posix_memalign, reallocf & valloc
Result:
alloc tests should pass again