Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

alloc tests: hook posix_memalign & reallocf (#782) #954

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

weissi
Copy link
Member

@weissi weissi commented Apr 8, 2019

Motivation:

Swift started using posix_memalign very recently (Jan 2019) so we need
to hook that too to get correct results.

Modifications:

Hook posix_memalign, reallocf & valloc

Result:

alloc tests should pass again

(cherry picked from commit de8d3e2)

Motivation:

Swift started using posix_memalign very recently (Jan 2019) so we need
to hook that too to get correct results.

Modifications:

Hook posix_memalign, reallocf & valloc

Result:

alloc tests should pass again

(cherry picked from commit de8d3e2)
@weissi weissi requested a review from Lukasa April 8, 2019 10:28
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Apr 8, 2019
@Lukasa Lukasa added this to the 1.14.0 milestone Apr 8, 2019
@Lukasa
Copy link
Contributor

Lukasa commented Apr 8, 2019

We're ignoring the Swift 5 test failure here: @weissi assures me that he expected that failure and that it's not relevant right now.

@weissi
Copy link
Member Author

weissi commented Apr 8, 2019

5.0 failure is expected because the docker file only comes in #952 (which can't go in ahead of this one because this backports the allocation counter fixes for Swift 5 from master)

@weissi weissi mentioned this pull request Apr 8, 2019
@weissi weissi merged commit b111dfc into apple:nio-1.14 Apr 8, 2019
@weissi weissi deleted the jw-backport-alloc-counters branch April 8, 2019 10:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants