Skip to content

[breaking] Removed redundant and useless commands from gRPC API #1891

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 13 commits into from
Oct 24, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 23, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Removes the gRPC commands:
  rpc UpdateCoreLibrariesIndex(UpdateCoreLibrariesIndexRequest) returns (stream UpdateCoreLibrariesIndexResponse) {}
  rpc Outdated(OutdatedRequest) returns (OutdatedResponse) {}
  rpc Upgrade(UpgradeRequest) returns (stream UpgradeResponse) {}
  • What is the current behavior?
    The code for these cli commands (execution, rendering, error reporting...) is duplicated from 2 to 3 times.
  • What is the new behavior?
    Removed all code duplication.
  • Does this PR introduce a breaking change, and is
    titled accordingly?

    Yes, the gRPC API calls described above have been removed.

@cmaglie cmaglie self-assigned this Sep 23, 2022
@cmaglie cmaglie added this to the Arduino CLI 1.0 milestone Oct 12, 2022
@cmaglie cmaglie force-pushed the grpc_cleanup_2_the_revenge branch 3 times, most recently from 4bfd5ab to bc2d934 Compare October 19, 2022 13:40
@cmaglie cmaglie marked this pull request as ready for review October 19, 2022 14:12
@cmaglie cmaglie requested review from umbynos and per1234 October 19, 2022 14:12
@cmaglie cmaglie added type: enhancement Proposed improvement priority: high Resolution is a high priority topic: gRPC Related to the gRPC interface criticality: low Of low impact labels Oct 19, 2022
@cmaglie cmaglie force-pushed the grpc_cleanup_2_the_revenge branch from bc2d934 to a9f48de Compare October 21, 2022 16:06
@cmaglie cmaglie merged commit 61ba685 into arduino:master Oct 24, 2022
@cmaglie cmaglie deleted the grpc_cleanup_2_the_revenge branch October 24, 2022 11:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
criticality: low Of low impact priority: high Resolution is a high priority topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants