Human sort nested lists #1333
Merged
Human sort nested lists #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaseemabid
requested review from
sambhav,
elliotgunton and
alicederyn
as code owners
jaseemabid
force-pushed
the
jabid/sort-nested-lists
branch
from
eac701f to
5714275
Compare
elliotgunton
added
semver:patch
|
Thanks @jaseemabid! It LGTM, I will just push the updated examples collection to the branch before merging 🚀 |
WF templates can have list of lists, for example steps. This PR makes sure those are sorted as well. Signed-off-by: Jaseem Abid <me@jabid.in>
elliotgunton
force-pushed
the
jabid/sort-nested-lists
branch
from
5714275 to
2588ce5
Compare
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
elliotgunton
approved these changes
Mar 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
=====================================
Coverage 86.5% 86.5%
=====================================
Files 60 60
Lines 4123 4127 +4
Branches 657 659 +2
=====================================
+ Hits 3567 3571 +4
Misses 388 388
Partials 168 168 ☔ View full report in Codecov by Sentry. |
|
Thank you! I was just about to update the PR with updated examples, took a while to read through the Makefile and figure it out. |
elliotgunton
pushed a commit
that referenced
this pull request
Mar 4, 2025
Just had to run `make regenerate-test-data` once, we probably forgot it last time. **Pull Request Checklist** - [X] Fixes #<!--issue number goes here--> - [X] Tests added - [x] Documentation/examples added - [X] [Good commit messages](https://cbea.ms/git-commit/) and/or PR title **Description of PR** Leftover from #1333 Signed-off-by: Jaseem Abid <me@jabid.in>
elliotgunton
added
type:skip-changelog
|
Just got our first internal PR that included this reordering, very nice ❤️ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WF templates can have list of lists, for example steps.
This PR makes sure those are sorted as well.
Ref #1326
Pull Request Checklist
Description of PR
I really haven't tested this throughly, but since you wrote the code only yesterday I'm guessing you would still have context @elliotgunton.
I can clean up, add some tests etc later when I get some time. Leaving this here as a draft for now.