Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Regenerate test data #1334

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

jaseemabid
Copy link
Contributor

@jaseemabid jaseemabid commented Mar 4, 2025

Just had to run make regenerate-test-data once, we probably forgot it last time.

Pull Request Checklist

Description of PR

Leftover from #1333

Just had to run `make regenerate-test-data` once, we probably forgot it
last time.

Signed-off-by: Jaseem Abid <me@jabid.in>
@jaseemabid jaseemabid force-pushed the jabid/regen-test-data branch from 7f96394 to 6560e42 Compare March 4, 2025 14:24
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.7%. Comparing base (e973bcb) to head (6560e42).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1334   +/-   ##
=====================================
  Coverage   86.7%   86.7%           
=====================================
  Files         60      60           
  Lines       4137    4137           
  Branches     663     663           
=====================================
  Hits        3589    3589           
  Misses       383     383           
  Partials     165     165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elliotgunton elliotgunton added the type:skip-changelog A change that does not require a changelog entry label Mar 4, 2025
Copy link
Collaborator

@elliotgunton elliotgunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was from the new example added in #1332, forgot to rerun it when rebasing on main 👍

@elliotgunton elliotgunton enabled auto-merge (squash) March 4, 2025 17:18
@elliotgunton elliotgunton merged commit 3efd276 into argoproj-labs:main Mar 4, 2025
23 of 25 checks passed
@jaseemabid
Copy link
Contributor Author

@elliotgunton Do you mind making a new minor release with these recent PRs including sorted yaml? That would help me not maintain an internal fork and all the other hassle that comes with it.

Also goes without saying, thank you for being a super responsive maintainer 🙌🏼. Very much appreciated.

@jaseemabid jaseemabid deleted the jabid/regen-test-data branch March 4, 2025 17:26
@elliotgunton
Copy link
Collaborator

Of course! Was intending to do a release after getting through some of these "minor version worthy" features. I think that's the last but will take a look through the issues first.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:skip-changelog A change that does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants