fix(appset): informer is not a kubernetes informer (#18905) #19618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19618 +/- ##
==========================================
+ Coverage 55.85% 55.90% +0.04%
==========================================
Files 316 316
Lines 43790 43776 -14
==========================================
+ Hits 24459 24473 +14
+ Misses 16779 16756 -23
+ Partials 2552 2547 -5 ☔ View full report in Codecov by Sentry. |
|
@alexmt does this seem reasonable, or should we dig further to find out how to write back to the informer? |
|
I've wasted a few hours and also could not find a way to access the underlying informer. PR makes sense to get rid of error message. |
|
Access the Informer Store with this One Easy Trick Kubernetes Maintainers Don't Want You to Know! |
|
/cherry-pick release-2.12 |
crenshaw-dev
added a commit
that referenced
this pull request
Aug 22, 2024
14 tasks
pasha-codefresh
pushed a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Oct 9, 2024
…rgoproj#19618) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateCachewas introduced in #15514 to avoid a bug where the appset controller would delete an app'sstatusfield.The PR had to changes: 1) use
patchinstead ofupdateand 2) write updates back to the informer to avoid stale data.I think the first change is probably enough to fix the bug.
With the latest controller runtime code, I'm not seeing a way to access the underlying data store to do write-backs. But maybe at this point it's not necessary anyway.
Fixes #18905