Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(appset): remove cache references #19647

Merged

Conversation

rumstead
Copy link
Member

@rumstead rumstead commented Aug 22, 2024

Remove references to the appset cache since it is no longer being used per #19618

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested a review from a team as a code owner August 22, 2024 18:50
Copy link

bunnyshell bot commented Aug 22, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 22, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) August 22, 2024 18:53
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.12

@crenshaw-dev crenshaw-dev merged commit 42c2349 into argoproj:master Aug 22, 2024
31 of 32 checks passed
Copy link

Cherry-pick failed with Merge error 42c2349d7c79131a0212c5a583d1b736eb92d17d into temp-cherry-pick-b67049-release-2.12

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.80%. Comparing base (457bb1f) to head (9809066).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19647      +/-   ##
==========================================
- Coverage   55.89%   55.80%   -0.09%     
==========================================
  Files         316      316              
  Lines       43779    43778       -1     
==========================================
- Hits        24469    24430      -39     
- Misses      16757    16794      +37     
- Partials     2553     2554       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants