Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: notification controller crash loop in 2.13 RC1 #19984

Conversation

pasha-codefresh
Copy link
Member

Closes: #19968

Signed-off-by: pashakostohrys <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh requested a review from a team as a code owner September 18, 2024 18:01
Copy link

bunnyshell bot commented Sep 18, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 18, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@pasha-codefresh pasha-codefresh changed the title fix: notificaion controller crash loop in 2.13 RC-1 fix: notificaion controller crash loop in 2.13 RC1 Sep 18, 2024
@crenshaw-dev crenshaw-dev changed the title fix: notificaion controller crash loop in 2.13 RC1 fix: notification controller crash loop in 2.13 RC1 Sep 18, 2024
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.13

@pasha-codefresh pasha-codefresh enabled auto-merge (squash) September 18, 2024 18:26
@pasha-codefresh pasha-codefresh merged commit 7f417e2 into argoproj:master Sep 18, 2024
27 of 29 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 18, 2024
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.81%. Comparing base (ae028c2) to head (57e6569).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd-notification/commands/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19984      +/-   ##
==========================================
- Coverage   55.81%   55.81%   -0.01%     
==========================================
  Files         320      320              
  Lines       44396    44397       +1     
==========================================
- Hits        24781    24780       -1     
- Misses      17050    17051       +1     
- Partials     2565     2566       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crenshaw-dev pushed a commit that referenced this pull request Sep 18, 2024
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications Controller Crashloops 2.13.0-rc1
2 participants