Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: notification controller crash loop in 2.13 RC1 (cherry-pick #19984) #19986

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix notificaion controller crash loop (#19984)

Signed-off-by: pashakostohrys pavel@codefresh.io

Signed-off-by: pashakostohrys <pavel@codefresh.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner September 18, 2024 18:56
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) September 18, 2024 18:59
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-2.13@425b408). Learn more about missing BASE report.
Report is 1 commits behind head on release-2.13.

Files with missing lines Patch % Lines
cmd/argocd-notification/commands/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-2.13   #19986   +/-   ##
===============================================
  Coverage                ?   55.84%           
===============================================
  Files                   ?      320           
  Lines                   ?    44382           
  Branches                ?        0           
===============================================
  Hits                    ?    24783           
  Misses                  ?    17029           
  Partials                ?     2570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 243ecc2 into release-2.13 Sep 18, 2024
20 of 25 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-353e91-release-2.13 branch September 18, 2024 20:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants