Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix pair_plot for mixed discrete and continuous variables #1434

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Oct 30, 2020

When plotting mixed variables plot_pair produced a wrong result, basically the type of the variable was taken from the first variable and applied to the rest.

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #1434 into master will increase coverage by 0.02%.
The diff coverage is 93.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   91.97%   91.99%   +0.02%     
==========================================
  Files         105      105              
  Lines       11173    11184      +11     
==========================================
+ Hits        10276    10289      +13     
+ Misses        897      895       -2     
Impacted Files Coverage Δ
arviz/plots/backends/matplotlib/pairplot.py 92.10% <90.90%> (+0.08%) ⬆️
arviz/plots/backends/bokeh/pairplot.py 88.48% <92.00%> (+1.66%) ⬆️
arviz/plots/pairplot.py 88.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead5c98...c5ccf5e. Read the comment docs.

@aloctavodia aloctavodia mentioned this pull request Nov 2, 2020
3 tasks
@aloctavodia aloctavodia merged commit d6603e6 into master Nov 3, 2020
@aloctavodia aloctavodia deleted the pair_discrete branch November 3, 2020 13:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants