This repository was archived by the owner on Nov 7, 2018. It is now read-only.
Undo breaking change to OptionsWrapper #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Mar 26, 2018
|
Can we mark them as obsolete per the guidelines mentioned in dotnet/aspnetcore#2983 ? |
|
Is that warning really necessary in this specific case given that its non virtual and throws if its ever called? |
|
I think it'd be good to follow the guidelines, because at least the docs will be correct for anyone looking at the API refs, though I agree it's surprising if anyone in practice was calling it. |
|
Okay if the docs will reflect it, that's pretty useful, I"ll send another PR |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/aspnetcore#2983
Filed https://github.com/aspnet/Home/issues/3002 to remove these in 3.0